Changeset 48

Timestamp:

Feb 23, 2010 6:12:09 PM (15 years ago)

Author:

retracile

Message:

Mergebot: convert an os.popen call to a subprocess call

File:

• mergebot/trunk/mergebot/svn.py (modified) (1 diff)

mergebot/trunk/mergebot/svn.py

@@ -60 +60 @@
         """Given a subversion url and a logfile, return (start_revision,
         end_revision) or None if it does not exist."""
-        svncmd = os.popen("svn log --stop-on-copy --non-interactive %s 2>>%s" \
-            % (url, logfile), "r")
-        branchlog = svncmd.read()
-        returnval = svncmd.close()
+        svncmd = subprocess.Popen(['svn', 'log', '--stop-on-copy', '--non-interactive', url], stdout=subprocess.PIPE, stderr=open(logfile, 'a'))
+        branchlog, stderr = svncmd.communicate()
+        returnval = svncmd.wait()
         if returnval:
             # This branch apparently doesn't exist